fix: provide coinbase proof #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sander2
force-pushed
the
spv-fix
branch
2 times, most recently
from
7b8efdc
to
1550ff9
Compare
gregdhill
reviewed
Jul 27, 2023
Comment on lines
+195
to
+208
| // construct height: see https://github.com/bitcoin/bips/blob/master/bip-0034.mediawiki | ||
| // first byte is number of bytes in the number (will be 0x03 on main net for the next | ||
| // 150 or so years with 223-1 blocks), following bytes are little-endian representation | ||
| // of the number (including a sign bit) | ||
| let mut height_bytes = height.to_le_bytes().to_vec(); | ||
| for i in (1..4).rev() { | ||
| // remove trailing zeroes, but always keep first byte even if it's zero | ||
| if height_bytes[i] == 0 { | ||
| height_bytes.remove(i); | ||
| } else { | ||
| break; | ||
| } | ||
| } | ||
| height_bytes.insert(0, height_bytes.len() as u8); |
There was a problem hiding this comment.
Can we not use the logic in the parsing crate here?
There was a problem hiding this comment.
I guess technically yes, but (1) it's not exposed and (2) we're not using the parachain's bitcoin types here, but rather the types used by the bitcoin core rpc. Both of these are not hard blockers but I think it makes it not worth it
gregdhill
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #501